This module has been revised with unofficial code changes.
Problem: Mod Fcgid children not being killed during a graceful restart/stop requiring administrator to have to kill them manually from the processes dialog in task manager or third party equivalent. This is an old bug that originally was in version 2.2. Due to the posted fix never making it into the code base before Apache took it over, it is still missing to this day.
The patches used are included with this distribution.
<![CDATA[Index ./modules/fcgid/fcgid_conf.h
===============================================================================
--- ./modules/fcgid/fcgid_conf.h (Original)
+++ ./modules/fcgid/fcgid_conf.h (Working)
@@ -31,7 +31,7 @@
#if MODFCGID_VERSION_DEV
#define MODFCGID_VERSION_DEVSTR "-dev"
#else
-#define MODFCGID_VERSION_DEVSTR ""
+#define MODFCGID_VERSION_DEVSTR "b"
#endif
#define MODFCGID_REVISION APR_STRINGIFY(MODFCGID_VERSION_MAJOR) \
Index ./modules/fcgid/fcgid_pm_main.c
===============================================================================
--- ./modules/fcgid/fcgid_pm_main.c (Original)
+++ ./modules/fcgid/fcgid_pm_main.c (Working)
@@ -375,7 +375,9 @@
proc->diewhy = FCGID_DIE_SHUTDOWN;
proc_print_exit_info(proc, exitcode, exitwhy,
main_server);
+#ifndef WIN32
apr_pool_destroy(proc->proc_pool);
+#endif
proc->proc_pool = NULL;
return 1;
}
Index ./modules/fcgid/fcgid_pm_win.c
===============================================================================
--- ./modules/fcgid/fcgid_pm_win.c (Original)
+++ ./modules/fcgid/fcgid_pm_win.c (Working)
@@ -124,6 +124,9 @@
exit(1);
}
+ apr_pool_cleanup_register(pconf, main_server,
+ procmgr_stop_procmgr, apr_pool_cleanup_null);
+
return APR_SUCCESS;
}
@@ -249,8 +252,6 @@
apr_status_t
procmgr_child_init(server_rec * main_server, apr_pool_t * pchild)
{
- apr_pool_cleanup_register(pchild, main_server,
- procmgr_stop_procmgr, apr_pool_cleanup_null);
return APR_SUCCESS;
}
]]>
NOTICE:
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS, CONTRIBUTORS AND THE APACHE HAUS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS OR THE APACHE HAUS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
Glossary
